Skip to content

Document REPAIRCLUSTER,REPAIRCLUSTERMETADATA privs #20030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2025
Merged

Document REPAIRCLUSTER,REPAIRCLUSTERMETADATA privs #20030

merged 2 commits into from
Aug 7, 2025

Conversation

rmloveland
Copy link
Contributor

Fixes:

@rmloveland rmloveland requested a review from rafiss July 30, 2025 18:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2025 •
edited
Loading

Files changed:

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 0ebf9ae
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6894eeefbd24e9000985b12e

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2025 •
edited
Loading

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 0ebf9ae
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6894eeef386c6d0008b990fc

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2025 •
edited
Loading

✅ Netlify Preview

Name Link
🔨 Latest commit 0ebf9ae
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6894eef0e9e4b20007b65d35
😎 Deploy Preview https://deploy-preview-20030--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rmloveland
Copy link
Contributor Author

@rmloveland remember to backport this to supported versions once it's reviewed!

@rafiss it looks from the code PR like this change applies to all supported versions v23.1+, is that correct?

rafiss
rafiss approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

The REPAIRCLUSTERMETADATA privilege was added in 23.2 (cockroachdb/cockroach#110609), so will this get added to the other release's docs pages too?

@rmloveland
Copy link
Contributor Author

lgtm!

awesome thanks!

The REPAIRCLUSTERMETADATA privilege was added in 23.2 (cockroachdb/cockroach#110609), so will this get added to the other release's docs pages too?

yes, once this gets a 2nd lgtm from a docs team reviewer I will backport to all the other docs for versions v23.2 and later

@rmloveland rmloveland requested a review from florence-crl August 5, 2025 20:41
florence-crl
florence-crl approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@florence-crl florence-crl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, non-blocking nit: you might consider using "modify" rather than "edit"

@rmloveland
Document REPAIRCLUSTER,REPAIRCLUSTERMETADATA privs
fe4d949 
Fixes DOC-8913

NB. Backported changes to supported versions v23.2+
@rmloveland rmloveland force-pushed the 20250730-DOC-9913-add-REPAIRCLUSTER-privilege branch from d16b2a7 to fe4d949 Compare August 7, 2025 18:21
@rmloveland
Copy link
Contributor Author

TFTRs! Backported changes to all supported versions v23.2+, merging ...

@rmloveland rmloveland enabled auto-merge (squash) August 7, 2025 18:22
@rmloveland rmloveland merged commit 4067075 into main Aug 7, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250730-DOC-9913-add-REPAIRCLUSTER-privilege branch August 7, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@florence-crl florence-crl florence-crl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmloveland @rafiss @florence-crl